sync: update CI config files

web3-bot commented 3 years ago

Syncing to commit https://github.com/protocol/.github/commit/c444802439eae549ab950774e3743c13a2e7a17d.

welcome[bot] commented 3 years ago

Thank you for submitting this PR! A maintainer will be here shortly to review it. We are super grateful, but we are also overloaded! Help us by making sure that:

The context for this PR is clear, with relevant discussion, decisions and stakeholders linked/mentioned.
Your contribution itself is clear (code comments, self-review for the rest) and in its best form. Follow the code contribution guidelines if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment. Next steps:

A maintainer will triage and assign priority to this PR, commenting on any missing things and potentially assigning a reviewer for high priority items.
The PR gets reviews, discussed and approvals as needed.
The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. We are very grateful for your contribution!

marten-seemann commented 3 years ago

Tests failing due to ipfs/go-bitswap#481.

We'll also have to disable CircleCI for this repo.

Stebalien commented 3 years ago

I'm going to just disable that test.

Stebalien commented 3 years ago

Nevermind. I'm updating my expectation on fixing these tests to 1 (maybe 2) days of head scratching. Luckily, most of this head scratching can be done by just about anyone.

BigLep commented 3 years ago

@coryschwartz : I'm working to get you access to this repo so I can assign this issue to you, but we want this to get merged during your rotation. Any flaky tests that you need to disable, can you create tracking issues for and add to https://github.com/ipfs/go-libipfs/issues/86 if they aren't already there?

coryschwartz commented 3 years ago

I broke up the big TestWantlistRebroadcast test, which was flaky. It passes now. There were multiple tests going on there and there might have been something goin on with the timing and rebroadcast intervals that was making it work inconstently.

◉ go test -count 1000 -run  TestWantlistRebroadcastBroadcastsAllWanthaves -run TestWantlistRebroadcastBroadcastInterval -run TestWantlistRebroadcastCancels
PASS
ok      github.com/ipfs/go-bitswap/internal/messagequeue        10.934s

Stebalien commented 3 years ago

@coryschwartz did you make your changes on this PR? If you still have them locally, please force-push them to a new PR. Unfortunately, the "auto deploy" logic is overwriting this PR.

Stebalien commented 3 years ago

I'm going to merge this as having broken CI is better than no CI.

ipfs / go-bitswap

sync: update CI config files #485