search

ipfs / go-bitswap

The golang implementation of the bitswap protocol
MIT License
216 stars 112 forks source link

Fix/fix test tagging useful #492

Closed hannahhoward closed 3 years ago

hannahhoward commented 3 years ago

Goals

fix #472

Implementation

The TestTaggingUseful test was flaky due to a very low test interval (1 millisecond) -- causing unpredictable behavior. I find it is pretty dangerous to rely on timers across OS that are <10 milliseconds. This does mean the test takes slightly longer, but should be much more reliable

hannahhoward commented 3 years ago

still failing on Windows. closing.