search

ipfs / go-bitswap

The golang implementation of the bitswap protocol
MIT License
216 stars 112 forks source link

Fix flaky tests in message queue #497

Closed hannahhoward closed 3 years ago

hannahhoward commented 3 years ago

Goals

Fix all the flaky tests of the message queue

Implementation

Once again, errors come down to timing, and I'm fixing by mocking time in flaky tests

In this case, I didn't actually go and replace all the tests, as this would be a big endeavor

part of ipfs/go-libipfs#86

dirkmc commented 3 years ago

Suggest merging https://github.com/ipfs/go-bitswap/pull/495 before reviewing this PR, as this PR appears to include those changes

Stebalien commented 3 years ago

Failing tests are unrelated.