search

ipfs / go-bitswap

The golang implementation of the bitswap protocol
MIT License
216 stars 112 forks source link

testing: skip flaky tests on failure so that CI can reliably pass #529

Closed aschmahmann closed 1 year ago

aschmahmann commented 3 years ago

I've taken the approach of only skipping the particular errors identified in https://github.com/ipfs/go-libipfs/issues/86. We still obviously need to fix these, but having CI green makes it easier to determine when an issue with a PR is new or not.

Note: It's possible that many of these tests are actually exposing bugs, the reason to disable is mostly so that it's possible to sanely review other PRs in the meanwhile without the temptation to ignore the big red X.

Stebalien commented 3 years ago

What's the status here? Is there any reason to skip things that aren't faulty?

aschmahmann commented 3 years ago

The status is that this PR is skipping tests that are flaky until CI starts being green. However, it looks like we have more flaky tests than just those mentioned in ipfs/go-libipfs#86 that are getting discovered wackamole style. I had timeboxed myself here, so the PR has some flaky tests disabled, but not enough to get CI green.

Jorropo commented 1 year ago

This repository has been moved to https://github.com/ipfs/go-libipfs. There is not an easy way to transfer PRs, so if you would like to continue with this PR then please re-open it in the new repository and link to this PR.