ipfs / go-bitswap

The golang implementation of the bitswap protocol
MIT License
216 stars 112 forks source link

increase histogram time bucket precision #545

Closed whyrusleeping closed 1 year ago

aschmahmann commented 2 years ago

@whyrusleeping have you tried this branch out and is it giving enough useful information?

aschmahmann commented 2 years ago

I'm weirded out that only the OS X tests are failing here and they're all failing with:

=== RUN   TestSessionFailingToGetFirstBlock
    session_test.go:450: did not rebroadcast whole live list
--- FAIL: TestSessionFailingToGetFirstBlock (0.10s)

Not sure why this PR would effect that though

whyrusleeping commented 2 years ago

@aschmahmann I ran it briefly, it does look better

BigLep commented 2 years ago

@aschmahmann : what do we want to do with this? What's the priority?

Jorropo commented 1 year ago

This repository has been moved to https://github.com/ipfs/go-libipfs. There is not an easy way to transfer PRs, so if you would like to continue with this PR then please re-open it in the new repository and link to this PR.