search

ipfs / go-bitswap

The golang implementation of the bitswap protocol
MIT License
216 stars 112 forks source link

Split client and server #570

Closed Jorropo closed 2 years ago

Jorropo commented 2 years ago

WIP

Closes #568

Jorropo commented 2 years ago

"it works on my machine" (I hate race conditions)

Maybe I should try rebasing this on some of your race fixing @guseggert ?

guseggert commented 2 years ago

Can't comment on renamed files, but shouldn't we leave /docs in the root dir instead of moving to /client/docs ?

Jorropo commented 2 years ago

Can't comment on renamed files, but shouldn't we leave /docs in the root dir instead of moving to /client/docs ?

Yeah I'll fix.

guseggert commented 2 years ago

Side note: on Windows and Mac, the TestSessionFailingToGetFirstBlock test is now consistently failing, but nothing was changed in that code. It was already racy and failing often to begin with. I'm guessing that the refactor changed the order that tests are run which is causing that to fail now. But since nothing was changed there, I'm going to move forward. We can fix that later.