search

ipfs / go-bitswap

The golang implementation of the bitswap protocol
MIT License
216 stars 112 forks source link

chore: update go-libp2p v0.22.0 #580

Closed Jorropo closed 2 years ago

Jorropo commented 2 years ago

This remove the github.com/libp2p/go-libp2p-loggables because AFAIT this is not usefull anymore (we use tracing now).

If people care about uuids in logs, we should log sessions in go-log instead.

Jorropo commented 2 years ago

@rvagg don't merge it's broken.

network/ipfs_impl_test.go:502:3: unknown field 'OpenedStreamF' in struct literal of type "github.com/libp2p/go-libp2p/core/network".NotifyBundle
network/ipfs_impl_test.go:505:3: unknown field 'ClosedStreamF' in struct literal of type "github.com/libp2p/go-libp2p/core/network".NotifyBundle
network/ipfs_impl_test.go:510:3: unknown field 'OpenedStreamF' in struct literal of type "github.com/libp2p/go-libp2p/core/network".NotifyBundle
network/ipfs_impl_test.go:513:3: unknown field 'ClosedStreamF' in struct literal of type "github.com/libp2p/go-libp2p/core/network".NotifyBundle
rvagg commented 2 years ago

@rvagg don't merge it's broken.

I wouldn't anyway, bitswap isn't really my area of expertise, I trust you on this one but the changes look good so far (other than failures)

Jorropo commented 2 years ago

Should be fixed (runs on my machine).