search

ipfs / go-bitswap

The golang implementation of the bitswap protocol
MIT License
216 stars 112 forks source link

Bitswap v0.10.1 is causing the lotus sync tests to fail reliably #584

Closed Stebalien closed 2 years ago

Stebalien commented 2 years ago

See https://github.com/filecoin-project/lotus/pull/9279. I'm not sure what's going on here, but this appears to be a pretty significant regression.

Jorropo commented 2 years ago

First issues are seen with v0.10.0 (so this is unrelated to the split and an issue with bumping go-libp2p)

Jorropo commented 2 years ago

It's not related to the removal of session uuids in logs (I tested with it back in and it still fails).

Stebalien commented 2 years ago

First issues are seen with v0.10.0 (so this is unrelated to the split and an issue with bumping go-libp2p)

Note: lotus uses libp2p v0.22.0. Did you test with another version?

Jorropo commented 2 years ago

Note: lotus uses libp2p v0.22.0. Did you test with another version?

No I just go get github.com/ipfs/go-bitswap@v0.9.0 && go mod tidy && go test -run=TestSyncMining ./chain inside lotus.