ipfs / go-cid

Content ID v1 implemented in go
MIT License
157 stars 47 forks source link

adding blake3 support, bumping versions #140

Closed laudiacay closed 2 years ago

laudiacay commented 2 years ago

adding blake3 stuff and bumping multihash version. bumping minor version here too.

welcome[bot] commented 2 years ago

Thank you for submitting this PR! A maintainer will be here shortly to review it. We are super grateful, but we are also overloaded! Help us by making sure that:

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment. Next steps:

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. We are very grateful for your contribution!

laudiacay commented 2 years ago

depends on this getting merged: https://github.com/multiformats/go-multihash/pull/158

Jorropo commented 2 years ago

Golang's dependency model is not tree like.

Except counting /v2, /v3, ... branches (which we are not using here). Only one version of the package is compiled (the latest one).

If a consumer (like go-ipfs) updates to a later go-multihash this also updates it for all other users of this module (like go-cid).

I think this can be closed, if someone need some custom go-multihash for some blake3 thing they can just update to the newer go-multihash.

laudiacay commented 2 years ago

phew one less to worry about.... so i guess we just need to bump go-verifcid on go-ipfs, and get the go-multihash bugfix in.