ipfs / go-cid

Content ID v1 implemented in go
MIT License
156 stars 47 forks source link

move _rsrch/cidiface into an internal package #169

Closed MichaelMure closed 1 day ago

MichaelMure commented 3 days ago

_rsrch/cidiface is an engineering experiment package to explore the right form for a CID. As such, it's not meant to be actually used, and could result in conflict if used.

To avoid accidentally importing it (or even getting suggestions to do so), this package is moved into an "internal" folder, hinting tooling that it's not meant for external consumption.

welcome[bot] commented 3 days ago

Thank you for submitting this PR! A maintainer will be here shortly to review it. We are super grateful, but we are also overloaded! Help us by making sure that:

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment. Next steps:

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. We are very grateful for your contribution!

MichaelMure commented 2 days ago

@rvagg FYI, I don't have the power to merge this myself.

rvagg commented 1 day ago

yeah, sorry, just giving others a chance to pipe up before merging