ipfs / go-datastore

key-value datastore interfaces
MIT License
228 stars 64 forks source link

Support Asynchronous Writing Datastores #140

Closed aschmahmann closed 4 years ago

aschmahmann commented 4 years ago

Per #137 we would like to support Datastores that internally have asynchronous writes. We are doing this by adding a Sync(prefix ds.Key) function to the Datastore interface.

The plan is: 1) Get this PR reviewed for a sanity check 2) Get the datastore PRs submitted and reviewed and ready to be accepted (their go.mod files will reference this PR's branch)

bonedaddy commented 4 years ago

After this PR is merged can we have a version bump according to semver practices since this is a breaking change to the Datastore interface?

Stebalien commented 4 years ago

After this PR is merged can we have a version bump according to semver practices since this is a breaking change to the Datastore interface?

We will bump the minor version because the package version is sub-zero.

bonedaddy commented 4 years ago

After this PR is merged can we have a version bump according to semver practices since this is a breaking change to the Datastore interface?

We will bump the minor version because the package version is sub-zero.

Won't break go get -u=patch so :rocket:

Stebalien commented 4 years ago

LGTM but let's merge this tomorrow. Hitting merge then going to bed is a bad idea (I mean, it's one of my favorite bad ideas but I think it's time to call it a day).