Closed aschmahmann closed 4 years ago
After this PR is merged can we have a version bump according to semver practices since this is a breaking change to the Datastore
interface?
After this PR is merged can we have a version bump according to semver practices since this is a breaking change to the Datastore interface?
We will bump the minor version because the package version is sub-zero.
After this PR is merged can we have a version bump according to semver practices since this is a breaking change to the Datastore interface?
We will bump the minor version because the package version is sub-zero.
Won't break go get -u=patch
so :rocket:
LGTM but let's merge this tomorrow. Hitting merge then going to bed is a bad idea (I mean, it's one of my favorite bad ideas but I think it's time to call it a day).
Per #137 we would like to support Datastores that internally have asynchronous writes. We are doing this by adding a
Sync(prefix ds.Key)
function to the Datastore interface.The plan is: 1) Get this PR reviewed for a sanity check 2) Get the datastore PRs submitted and reviewed and ready to be accepted (their go.mod files will reference this PR's branch)
Sync()
command on their datastores 6) Switch the default datastore in go-ipfs to be an asynchronous one (i.e. Badger with Async writes enabled)