ipfs / go-datastore

key-value datastore interfaces
MIT License
228 stars 64 forks source link

Add test to ensure that Delete returns no error for missing keys #162

Closed ncabatoff closed 4 years ago

ncabatoff commented 4 years ago

Make sure that Delete does not treat a missing key as an error. Would've caught https://github.com/ipfs/go-ds-crdt/issues/62.

welcome[bot] commented 4 years ago

Thank you for submitting this PR! A maintainer will be here shortly to review it. We are super grateful, but we are also overloaded! Help us by making sure that:

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment. Next steps:

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. We are very grateful for your contribution!