ipfs / go-ds-crdt

A distributed go-datastore implementation using Merkle-CRDTs.
Other
397 stars 43 forks source link

Please close the psubTopic #227

Open wenyue opened 7 months ago

wenyue commented 7 months ago

Please close the psubTopic when the context is done.

welcome[bot] commented 7 months ago

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review. In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment. Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

Finally, remember to use https://discuss.ipfs.io if you just need general support.

hsanjuan commented 7 months ago

Can you be more specific/provide more details?

wenyue commented 7 months ago

In the NewPubSubBroadcaster function,we join and create a psubTopic object, and this object should be closed when the context is done.

wenyue commented 7 months ago

Any update?

hsanjuan commented 7 months ago

Mind sending a PR?