search

ipfs / go-ds-flatfs

A datastore implementation using sharded directories and flat files to store data
MIT License
46 stars 21 forks source link

Comments, documentations and questions #105

Closed MichaelMure closed 2 years ago

MichaelMure commented 2 years ago

While I was trying to understand that code, I added some comment and documentation to make that process easier for the next person.

I also found a possible bug (https://github.com/ipfs/go-ds-flatfs/commit/26abf67dbdb624fa313b7fcd7d26a17ee3c18b89). It looks like a mistake as fs here can't be nil.

Additionally, I'm confused about certain things or noticed some possible improvement (https://github.com/ipfs/go-ds-flatfs/commit/846fdf9a6fa8caf7784649a458d6f8d72cb87c20). I'm using that PR as a way to discuss those points, this last commit can be removed after that.

MichaelMure commented 2 years ago

I think the questions have been discussed enough, we can remove the last commit and merge the rest.

BigLep commented 2 years ago

2022-06-03: @aschmahmann will handle this today as part of PR review day.