Closed Jorropo closed 1 year ago
Thank you for submitting this PR! A maintainer will be here shortly to review it. We are super grateful, but we are also overloaded! Help us by making sure that:
The context for this PR is clear, with relevant discussion, decisions and stakeholders linked/mentioned.
Your contribution itself is clear (code comments, self-review for the rest) and in its best form. Follow the code contribution guidelines if they apply.
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment. Next steps:
A maintainer will triage and assign priority to this PR, commenting on any missing things and potentially assigning a reviewer for high priority items.
The PR gets reviews, discussed and approvals as needed.
The PR is merged by maintainers when it has been approved and comments addressed.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. We are very grateful for your contribution!
Found with @Arlodotexe
I overlooked it didn't built ... :'( thx
I'll release after I get an O_TMPFILE
patch ready for linux.
This code was broken, it computed the size hint to do nothing with it.
Found with this profile:
This profile clearly show a pattern of
append
's growth. With this new code the only way toappend
is if the size hint undershoot (which would require more data to be written between theSize
andRead
calls). Might be worth apanic("race")
or returning an error if that happen ?