move retries lower and retry rename ops

ipfs / go-ds-flatfs

A datastore implementation using sharded directories and flat files to store data

MIT License

46 stars 21 forks source link

move retries lower and retry rename ops #82

Closed Stebalien closed 4 years ago

Stebalien commented 4 years ago

@willscott could you check this logic thoroughly. I think I got everything right, but I'm not sure.

Stebalien commented 4 years ago

We were also retrying put/delete write operations, which are no longer retried. I think transient failures in those aren't as much as much of a problem, but noting the functional change.

Yeah. I don't think we should be retrying write operations, but we probably should retry remove operations.

Stebalien commented 4 years ago

Ok, I've added retries to the delete ops as well.