support for Query.ReturnSizes - Githubissues

ipfs / go-ds-leveldb

An implementation of go-datastore using leveldb

MIT License

37 stars 21 forks source link

support for Query.ReturnSizes #34

Closed MichaelMure closed 4 years ago

MichaelMure commented 4 years ago

In https://github.com/ipfs/go-datastore/pull/134 is added a new request field in queries: Query.ReturnSizes.

To honor this field, datastore implementations can either:

return the size of the entry in Entry.Size if Query.ReturnSizes is set, or -1 otherwise
consider that returning the size doesn't imply a performance cost and always return the size in Entry.Size