ipfs / go-ds-s3

An s3 datastore implementation
MIT License
236 stars 66 forks source link

Plugin doesn't work with customer IPFS_PATH #272

Closed kallisti5 closed 11 months ago

kallisti5 commented 11 months ago

ipfs@ipfs:~$ pwd
/srv/ipfs

ipfs@ipfs:~$ find .
.
./plugins
./plugins/go-ds-s3-plugin
./.ipfs
./.ipfs/plugins
./.ipfs/plugins/go-ds-s3-plugin

ipfs@ipfs:~$ IPFS_PATH=/srv/ipfs ipfs init
generating ED25519 keypair...done
peer identity: 12D3KooWLxaqsnE4pJwtAHYdL33861P8JxQYxJfTgLMAWrTxbY9L
initializing IPFS node at /srv/ipfs

ipfs@ipfs:~$ cat config | grep s3

ipfs@ipfs:~$ cat config | grep -A4 Plugins
  "Plugins": {
    "Plugins": null
  },
  "Pinning": {
    "RemoteServices": {}
  },

ipfs@ipfs:~$ cat config | grep -A10 mounts
      "mounts": [
        {
          "child": {
            "path": "blocks",
            "shardFunc": "/repo/flatfs/shard/v1/next-to-last/2",
            "sync": true,
            "type": "flatfs"
          },
          "mountpoint": "/blocks",
          "prefix": "flatfs.datastore",
          "type": "measure"
welcome[bot] commented 11 months ago

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review. In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment. Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

Finally, remember to use https://discuss.ipfs.io if you just need general support.

hsanjuan commented 11 months ago

did you put the plugin in $IPFS_PATH/plugins ?

kallisti5 commented 11 months ago

yes. sorry. ipfs's home directory is /srv/ipfs as well :-) (where that find is being run)

hsanjuan commented 11 months ago

You need to edit the config to use it. It does not happen automagically on init i think.

kallisti5 commented 11 months ago

oh... the readme doesn't mention that. It just says to install the plugin by placing it on the filesystem and running init.

kallisti5 commented 11 months ago

oooh. You have to add the mount spec for the s3 storage provider after the init.. That wasn't super clear (it sounded like the plugin would add that section at init.

hsanjuan commented 11 months ago

I'll fix that