ipfs / go-graphsync

Initial Implementation Of GraphSync Wire Protocol
Other
100 stars 38 forks source link

Graphsync does not return an error when the request context is cancelled #142

Closed dirkmc closed 3 years ago

dirkmc commented 3 years ago

We found a problem in go-data-transfer whereby when the node shuts down

We worked around this problem by checking the if the request context was closed when the request finishes: https://github.com/filecoin-project/go-data-transfer/pull/134. The correct solution would be to fix the underlying problem, which appears to be that graphsync does not return an error when the request context is cancelled.

hannahhoward commented 3 years ago

This is no longer true I think