ipfs / go-graphsync

Initial Implementation Of GraphSync Wire Protocol
Other
100 stars 38 forks source link

DoNotSend extension should NOT send ALL cids receieved #203

Closed aarshkshah1992 closed 3 years ago

aarshkshah1992 commented 3 years ago

To support transfer resumption, a Graphsync requestor sends a DoNotSendCids message to the responder with ALL the CIDs received so far. This solution does NOT scale as sending ALL cids recieved for large data transfers causes the message size to exceed the message size limits set by the Graphsync protocol.

We need to redesign the DoNotSendCIds extension.

welcome[bot] commented 3 years ago

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review. In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment. Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

Finally, remember to use https://discuss.ipfs.io if you just need general support.

aarshkshah1992 commented 3 years ago

@whyrusleeping @raulk - If you guys wanna subscribe to this.

aarshkshah1992 commented 3 years ago

Moving this to go-data-transfer as @hannahhoward has a point that this needs to be fixed there as the DoNotSendCIds has uses cases beyond transfer resumption as well and does it's job correctly.