search

ipfs / go-graphsync

Initial Implementation Of GraphSync Wire Protocol
Other
100 stars 38 forks source link

Investigate flaky trace data inspection in TestPauseResumeViaUpdate #315

Closed rvagg closed 2 years ago

rvagg commented 2 years ago

https://github.com/ipfs/go-graphsync/runs/4514494584?check_suite_focus=true

      graphsync_test.go:821: 
            Error Trace:    tracing.go:123
                                        graphsync_test.go:821
            Error:          "[]" should have 1 item(s), but has 0
            Test:           TestPauseResumeViaUpdate
            Messages:       expected one event in span response(0)->executeTask(0)
  --- FAIL: TestPauseResumeViaUpdate (0.37s)

First time I've seen this one fail like this. This test has strictly two response(0)->executeTask(x) spans and the first one is supposed to pick up the Pause update so has a hooks.ErrPaused exception event on it. The failure here is showing that the first one doesn't have that event. Perhaps it's on the second, but that would be unexpected I think and I'm not sure that makes sense.

Need to repro and investigate.

rvagg commented 2 years ago

I'm going to call this one resolved thanks to the recent work Hannah put in to cleaning up other flaky areas related to tracing. I'll keep a loop running in the background while I'm AFK this afternoon just in case, but I haven't seen it in CI recently.