ipfs / go-graphsync

Initial Implementation Of GraphSync Wire Protocol
Other
100 stars 38 forks source link

fix(responsemanager): send update while completing #360

Closed hannahhoward closed 2 years ago

hannahhoward commented 2 years ago

If request has finished selector traversal but is still sending blocks, I think it should be possible to send updates. As a side effect, this fixes our test race.

Logically, this makes sense, cause our external indicator that we're done (completed response listener) has not been called.

rvagg commented 2 years ago

oh, interesting catch! thanks for figuring this one out, I wouldn't have got that I think