search

ipfs / go-graphsync

Initial Implementation Of GraphSync Wire Protocol
Other
100 stars 38 forks source link

feat(ipld): wrap bindnode with panic protection #368

Closed rvagg closed 2 years ago

rvagg commented 2 years ago

I meant to do this earlier but got stuck with other things. Just simple panic protection around bindnode use since bindnode is so new and we're still ironing out issues with it.

rvagg commented 2 years ago

mm, but I'm not sure that approach is going to work, or at least it might be difficult to pull off, since graphsync maintains pools of workers for some tasks and shared workers for others; it's not as straightforward as one overarching goroutine per request.

mvdan commented 2 years ago

That's fair, I just wanted to point that out. Being safe from bindnode panics is nice, but it's not the only worrying part of graphsync :)