ipfs / go-graphsync

Initial Implementation Of GraphSync Wire Protocol
Other
100 stars 38 forks source link

Backwards compatibility for ipldbridge #82

Closed jsonsivar closed 4 years ago

jsonsivar commented 4 years ago

Hello - so our project Space (https://github.com/fleekhq/space-daemon) is using both github.com/textileio/textile and go-ipfs. Textile brings in some Filecoin dependencies so there is now a conflict in the expected version of go-graphsync between Filecoin and go-ipfs.

The problem is that since ipldbridge was removed after v0.0.5 in this repo, go-ipfs v0.6.0 still depends on that. Meanwhile the Filecoin dependencies listed here need a newer version of go-graphsync:

463:github.com/filecoin-project/go-fil-markets@v0.3.0 github.com/ipfs/go-graphsync@v0.0.6-0.20200504202014-9d5f2c26a103
537:github.com/filecoin-project/lotus@v0.4.0 github.com/ipfs/go-graphsync@v0.0.6-0.20200504202014-9d5f2c26a103
671:github.com/filecoin-project/go-data-transfer@v0.3.0 github.com/ipfs/go-graphsync@v0.0.6-0.20200504202014-9d5f2c26a103

Are there plans to make this compatible with both Filecoin and IPFS? Apologies if this isn't the best place to post this, maybe it should be done on the Filecoin side but thought I'd start here and get some input before proceeding. Thanks in advance!

welcome[bot] commented 4 years ago

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review. In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment. Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

Finally, remember to use https://discuss.ipfs.io if you just need general support.

ribasushi commented 4 years ago

@aschmahmann I will look into this today, response should come in by EOD eastern

ribasushi commented 4 years ago

@jsonsivar branch https://github.com/ipfs/go-ipfs/tree/chore/bump-graphsync-dep should take care of your problem. Please test it when time permits and report back. Apologies for the delays!

jsonsivar commented 4 years ago

@jsonsivar branch https://github.com/ipfs/go-ipfs/tree/chore/bump-graphsync-dep should take care of your problem. Please test it when time permits and report back. Apologies for the delays!

Thank you for this @ribasushi. Will give it a shot and confirm here. cc @maurycy

jsonsivar commented 4 years ago

@ribasushi Just tested this out and it fixed it :+1: Thanks again. Not sure if we need to wait for it to get merged before closing this but will let you close it as you see fit. Is it safe to assume this fix will be in the next release of go-ipfs?

hannahhoward commented 4 years ago

thanks @ribasushi yep the solution is for sure to upgrade graphsync in IPFS

ribasushi commented 4 years ago

This is merged/in RC Closing