ipfs / go-ipfs-api

The go interface to ipfs's HTTP API
MIT License
454 stars 178 forks source link

Add ls and add swarming commands #270

Closed samuelbacaner closed 2 years ago

samuelbacaner commented 2 years ago

This PR adds the /swarm/peering/ls and /swarm/peering/add commands. I'm working on a project where these commands would be really useful so putting this PR up for consideration.

In order to test, I pulled down ipfs/kubo, ran docker compose up, and ran the shell_test.go against the container.

welcome[bot] commented 2 years ago

Thank you for submitting this PR! A maintainer will be here shortly to review it. We are super grateful, but we are also overloaded! Help us by making sure that:

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment. Next steps:

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. We are very grateful for your contribution!

sam-bacaner commented 2 years ago

@aschmahmann , tagging you as a recent contributor. I don't see any kind of needs-triage tag or similar. Please let me know if there's anything I can do to help you or others review this PR.

Stebalien commented 2 years ago

Thanks! Especially for writing the test!

sam-bacaner commented 2 years ago

Of course! Thanks for the quick review!