ipfs / go-ipfs-api

The go interface to ipfs's HTTP API
MIT License
454 stars 178 forks source link

need to support a Filestore nocopy option #275

Open ec1oud opened 1 year ago

ec1oud commented 1 year ago

Kubo has FilestoreEnabled as an experimental option. I think not duplicating data (and not storing it in an obfuscated way, when I've already got the files that I want to share, and intend to keep them in the same place) is an obvious good idea: IMO it should no longer be experimental unless there are too many things that can go wrong. https://github.com/ipfs/kubo/blob/master/docs/experimental-features.md#ipfs-filestore says "Needs more people to use and report on how well it works"; but having API support for this would be a good way to get more people to use it.

welcome[bot] commented 1 year ago

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review. In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment. Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

Finally, remember to use https://discuss.ipfs.io if you just need general support.

Jorropo commented 1 year ago

Filestore has corruptions issue if you modify / remove / move files that are still stored in filestore, it's probably not gonna get unexperimentalled at any time in favor of reflinking (same trick but done by the kernel with Copy-On-Write so no corruption possible).

We have two Kubo go api clients for history reasons, the other one have it afaik. https://github.com/ipfs/go-ipfs-http-client

If you want to add it to this package I'll be happy to review it.