ipfs / go-ipfs-api

The go interface to ipfs's HTTP API
MIT License
455 stars 178 forks source link

shell.Add always wraps a folder even only one file is added #277

Closed CsterKuroi closed 1 year ago

CsterKuroi commented 2 years ago

This is a big overhead for systems that often add a single file when use go-ipfs-api.

welcome[bot] commented 2 years ago

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review. In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment. Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

Finally, remember to use https://discuss.ipfs.io if you just need general support.

CsterKuroi commented 2 years ago

https://github.com/ipfs/go-ipfs-api/blob/42a3388734299b72d7719a4f1b728d78e0a2e164/add.go#L65

guseggert commented 1 year ago

This should be addressed as part of https://github.com/ipfs/kubo/issues/9124

lidel commented 1 year ago

We will not spend time on improving this library, let's continue in https://github.com/ipfs/kubo/issues/9124