search

ipfs / go-ipfs-chunker

go-ipfs-chunkers provides Splitter implementations for data before being ingested to IPFS
MIT License
31 stars 37 forks source link

fix size-0 chunker bug #9

Closed kjzz closed 6 years ago

kjzz commented 6 years ago

fix bug go-ipfs #5542

kjzz commented 6 years ago

@kevina yeah ,if we change to NewSizeSplitter(r io.Reader, size int64) (Splitter,error),i will influence other package who use this function.It is a compromise to fix this bug. WDYT?
And if you decide to do this , i am willing to di it. You can assign it to me,Thx a lot.

Stebalien commented 6 years ago

You're both right. Yes, it's a breaking change but the current behavior is buggy anyways so I'd make the change and fix dependent packages.