ipfs / go-ipfs-cmds

IPFS commands package
MIT License
50 stars 42 forks source link

allow header and set header in client #222

Closed hunjixin closed 2 years ago

hunjixin commented 2 years ago

need send Authorization header to remote exec cmds. allow header and support set header value in client

welcome[bot] commented 2 years ago

Thank you for submitting this PR! A maintainer will be here shortly to review it. We are super grateful, but we are also overloaded! Help us by making sure that:

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment. Next steps:

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. We are very grateful for your contribution!

hunjixin commented 2 years ago

@Stebalien

hunjixin commented 2 years ago

anyone can review this pr?

BigLep commented 2 years ago

@hunjixin: are you able to add the test so we can get this merged?

hunjixin commented 2 years ago

@BigLep have tested

BigLep commented 2 years ago

Thanks. We're blocked on finding maintainer review time. It's in the queue though.

Stebalien commented 2 years ago

Merged in https://github.com/ipfs/go-ipfs-cmds/pull/226 (addressing my review). Thanks!