ipfs / go-ipfs-cmds

IPFS commands package
MIT License
50 stars 42 forks source link

fix(http): return error in case of panic #250

Closed fabiobozzo closed 7 months ago

fabiobozzo commented 8 months ago

Address issue: https://github.com/ipfs/go-ipfs-cmds/issues/249

The new tests cover a case of sync http commands (e.g. /cat) and 'progress' commands (e.g. /add) panicking.

welcome[bot] commented 8 months ago

Thank you for submitting this PR! A maintainer will be here shortly to review it. We are super grateful, but we are also overloaded! Help us by making sure that:

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment. Next steps:

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. We are very grateful for your contribution!

Stebalien commented 7 months ago

Thanks!

Stebalien commented 7 months ago

(and thanks for writing a test)