Not compatible with `github.com/ipfs/kubo@v0.18.1`

kylos101 commented 1 year ago

Description

Projects that depend on ipfs/kubo@v0.18.1 cannot use ipfs/go-ipfs-http-client@v0.4.0. If we try, we get errors like:

go build .
# github.com/libp2p/go-libp2p-core/network
../../../go/pkg/mod/github.com/libp2p/go-libp2p-core@v0.20.1/network/rcmgr.go:166:27: network.NullResourceManager (type) is not an expression

go mod why github.com/libp2p/go-libp2p-core/network
# github.com/libp2p/go-libp2p-core/network
github.com/ipfs/go-ipfs-http-client
github.com/libp2p/go-libp2p-core/network

ipfs/go-ipfs-http-client depends on:

https://github.com/ipfs/go-ipfs-http-client/blob/171fcd55e3b743c38fb9d78a34a3a703ee0b5e89/go.mod#L12

Which depends on:

https://github.com/ipfs/go-ipfs-http-client/blob/171fcd55e3b743c38fb9d78a34a3a703ee0b5e89/go.mod#L15

But is archived and contains deprecated methods like:

https://github.com/libp2p/go-libp2p-core/blob/654214c1b3401c0363ef464ce9db7e1b04a7ef3f/network/rcmgr.go#L165-L166

Potential next steps?

Refactor ipfs/interface-go-ipfs-core to depend on github.com/libp2p/go-libp2p@v0.24.2, and use its core package instead of github.com/libp2p/go-libp2p-core@v0.8.6
Update ipfs/go-ipfs-http-client to use the new ipfs/interface-go-ipfs-core using github.com/libp2p/go-libp2p@v0.24.2

Anything else

I wanted to surface an issue to the community to get it's corresponding guidance. Let me know what you think? :pray:

welcome[bot] commented 1 year ago

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review. In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment. Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

"Priority" labels will show how urgent this is for the team.
"Status" labels will show if this is ready to be worked on, blocked, or in progress.
"Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

philwinder commented 1 year ago

Commenting to subscribe to this issue. https://github.com/filecoin-project/bacalhau cannot upgrade kubo until this is fixed, because we also use this http client.

ipfs / go-ipfs-http-client