search

ipfs / go-ipld-format

IPLD Node and Resolver interfaces in Go
https://github.com/ipld/ipld
MIT License
64 stars 26 forks source link

rename EndOfDag to ErrEndOfDag #61

Closed marten-seemann closed 3 years ago

marten-seemann commented 3 years ago

staticcheck is requesting this.

Unfortunately, this is an API breaking change. As far as I can see, we'll only have to update unixfs, but there's no guarantee I didn't miss any other repo.

Stebalien commented 3 years ago

I'd just tell staticcheck to not lint this. This is like io.EOF, it's not really an error.

In retrospect, we probably should have just returned a "done" boolean...

marten-seemann commented 3 years ago

Changed in #62.