search

ipfs / go-unixfsnode

An ADL IPLD prime node that wraps go-codec-dagpb's implementation of protobuf to enable pathing
Other
11 stars 5 forks source link

Fail to construct preload hamt shards when traversal fails #55

Closed willscott closed 1 year ago

willscott commented 1 year ago

Fix #54

rvagg commented 1 year ago

We could memoize the err inside UnixFSHAMTShard so the next call to a method that returns an error can return it. Unfortunately, by saying 0 to the Length() call we're minimising the chance that another method is going to be called on it.

willscott commented 1 year ago

given that 0 length leaves us unlikely to get the memoized error, i think i'm going to not add the complexity for that.