feat!: upgrade to helia 5

ipfs / helia-verified-fetch

A fetch-like API for obtaining verified & trustless IPFS CIDs on the web

https://npmjs.com/package/@helia/verified-fetch

Other

20 stars 5 forks source link

feat!: upgrade to helia 5 #107

Closed 2color closed 1 month ago

2color commented 1 month ago

Description

Upgrade Helia to v5 and js-libp2p to v2
Fix breaking changes

Change checklist

[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation if necessary (this includes comments as well)
[x] I have added tests that prove my fix is effective or that my feature works

2color commented 1 month ago

We've lost the .code property so anyone making decisions on thrown errors needs another way to do it, libp2p/helia now use .name - here we're not using anything at all so the dev has to do it based on error messages which can be fragile.

I've adapted to code to either reuse or define custom error types with the name property here.

2color commented 1 month ago

It seems that somehow this PR has caused a regression in the Gateway Conformance.

@SgtPooki Any pointers on debugging this?

achingbrain commented 1 month ago

You may wish to change the PR title before merging. chore: will not cause a release but you've added ! which means a breaking change so maybe you do want a release. Suggest deps!: or feat!: or something.

achingbrain commented 1 month ago

It doesn't look like the gateway conformance tests have passed for months: https://github.com/ipfs/helia-verified-fetch/actions/workflows/gateway-conformance.yml

github-actions[bot] commented 1 month ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 month ago

:tada: This PR is included in version @helia/verified-fetch-v2.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: