fix: allow passing cid encoded ipns keys

2color commented 1 month ago

Description

Fixes a bug whereby passing a base36 encoded IPNS key, e.g. ipns://k51qzi5uqu5dhp48cti0590jyvwgxssrii0zdf19pyfsxwoqomqvfg6bg8qj3s, throws an error: helia:verified-fetch:parse-url-string:error could not parse PeerId string "k51qzi5uqu5dhp48cti0590jyvwgxssrii0zdf19pyfsxwoqomqvfg6bg8qj3s" +0ms InvalidParametersError: Please pass a multibase decoder for strings that do not start with "1" or "Q"

[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation if necessary (this includes comments as well)
[x] I have added tests that prove my fix is effective or that my feature works

2color commented 1 month ago

Based on https://github.com/libp2p/js-libp2p/issues/2772#issuecomment-2428941432, I've implemented the handling of CID enocded PeerIDs in here.

github-actions[bot] commented 1 month ago

:tada: This PR is included in version @helia/verified-fetch-v2.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: