feat: require content-type parser to set content-type - Githubissues

ipfs / helia

An implementation of IPFS in JavaScript

https://helia.io

Other

814 stars 81 forks source link

feat: require content-type parser to set content-type #423

Closed SgtPooki closed 4 months ago

SgtPooki commented 4 months ago

Title

feat: require content-type parser to set content-type

Description

adds contentTypeParser function to createVerifiedFetch options & implements it.
renamed getStreamAndContentType to getStreamFromAsyncIterable that now returns a stream with the firstChunk seen, so we can pass it to the contentTypeParser function.
updates tests in packages/verified-fetch & packages/interop
updates packageDocumentation with example

Related https://github.com/ipfs/helia/pull/416 Fixes https://github.com/ipfs/helia/issues/422

Notes & open questions

feat: require content-type parser to set content-type
test: remove vFetch interop content-type assertions
docs: add content-type customization example

Change checklist

[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation if necessary (this includes comments as well)
[x] I have added tests that prove my fix is effective or that my feature works

achingbrain commented 4 months ago

~~We may wish to also pass the file name to contentTypeParser if it's available? This way if it's passed index.html it can just use the extension to return text/html instead of nothing.~~

This is done now ✅