fix: use CID object for verified-fetch progress events - Githubissues

ipfs / helia

An implementation of IPFS in JavaScript

https://helia.io

Other

916 stars 95 forks source link

fix: use CID object for verified-fetch progress events #425

Closed achingbrain closed 7 months ago

achingbrain commented 7 months ago

Do not stringify CIDs before using them as events.

The user can do this if they want, parsing them back to objects is not free.

Notes & open questions

I'm not sure why these were strings in the first place.

Change checklist

[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation if necessary (this includes comments as well)
[x] I have added tests that prove my fix is effective or that my feature works