ipfs / helia

An implementation of IPFS in JavaScript
https://helia.io
Other
814 stars 81 forks source link

test: re-enable hamt-test in interop #450

Closed SgtPooki closed 4 months ago

SgtPooki commented 4 months ago

Based on fix from https://github.com/ipfs/helia/pull/448, only including e0f8d5e791082b15661e7276bf241d907bd5f59f & 3c400806f4dcaaf7cd6e4ed5ef7aa87673c1d57e, and then copying over some code from ipfs-unixfs-exporter

Title

Description

Re-enables the hamt-sharded test since it's reliably passing before 60 second timeout now (roughly 40seconds on my machine)

Notes & open questions

Until the fix in https://github.com/ipfs/helia/pull/448 is sufficient, this should not be merged. We should decide on the proper fix, and utilize this test to ensure things are working as expected.

Change checklist

achingbrain commented 4 months ago

Please take a look at https://github.com/ipfs/helia/pull/455 - it also re-enables this test but uses the ipfs-unixfs-exporter to do the DAG traversal so we don't need to copy/paste any code from anywhere.

SgtPooki commented 4 months ago

Closing in favor of #455