fix: remove wants from wantlist when multiple block retrievers are used - Githubissues

ipfs / helia

An implementation of IPFS in JavaScript

https://helia.io

Other

812 stars 81 forks source link

fix: remove wants from wantlist when multiple block retrievers are used #491

Closed achingbrain closed 2 months ago

achingbrain commented 2 months ago

Fixes a bug where sometimes a wanted CID was not removed from the wantlist when it was retrieved by an alternative block retriever.

Also switches to using events for block/presence arrival to remove shared promises.

Change checklist

[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation if necessary (this includes comments as well)
[x] I have added tests that prove my fix is effective or that my feature works