ipfs / helia

An implementation of IPFS in JavaScript
https://helia.io
Other
811 stars 81 forks source link

fix: do not depend on external domains in dnslink tests #547

Closed lidel closed 1 month ago

lidel commented 1 month ago

Dependency on third-party domains means that over time CI will break, like it did in https://github.com/ipfs/kubo/actions/runs/9214249430/job/25364989609?pr=10429#step:9:63

Error: queryCname ENODATA singularity.storage

The three domains I left are stable and under IPFS Foundation / Shipyard control.

Ideally, CI would not depend on internet DNS, and have static fixtures and custom localhost DNS server, but this PR should be good enough to stop breaking CI on other project's PRs like https://github.com/ipfs/kubo/pull/10429

Notes & open questions

Change checklist

SgtPooki commented 1 month ago

Fyi current helia-verified-fetch gwc PR (todo link) has some dnsLink stubbing code (IPFS_NS_MAP like functionality)