search

ipfs / infra

Tools and systems for the IPFS community
MIT License
133 stars 41 forks source link

CI trigger #464

Closed Elexy closed 2 years ago

Elexy commented 5 years ago

This issue is to start the process of triggering the benchmarks from the new CI system. A sample curl command can be found here The benchmark run can be triggered based on a specific commit of the js-ipfs repository.

As of writing we are still working on publishing the results of the clinic investigations on IPFS and providing a usable url in the response.

Let me know if you need more help

eefahy commented 5 years ago

Can you say more about how you see this working? How can CI know when a benchmark is to to be kicked off? On merges to master? On a specific branch? or perhaps a particular tag?

cc: @alanshaw

Elexy commented 5 years ago

Let's start with triggering a run on each merge to master

possibly down the line we could build a way to track performance progress of a PR or branch and add filtering options to Grafana for that.

In the case of CircleCI this step would filter as such:

workflows:
  version: 2
  build_and_test:
    jobs:
      - step-1
      ...
      - step-3
      - benchmark:
          requires:
            - step-3
          filters:
            branches:
              only: master
      - step-4
eefahy commented 5 years ago

@alanshaw - thoughts on how this should be implemented?