Open lidel opened 2 years ago
I may look into this as an excuse to fix MV2 build. cc @meandavejustice – just FYI in case this edge case comes up in MV3 work
Just flagging this is still broken, https://www.4everland.org/ gets redirected to http://bafybeia5jy6dd66beizcfk4clmobokuph7oq5jl5aobesjzyfblcjdrtma.ipfs.localhost:8080/ and user is stuck on snapshot URL, and not live URL that can get updates.
$ curl https://www.4everland.org -is | grep -i x-ipfs-path
x-ipfs-path: /ipfs/bafybeia5jy6dd66beizcfk4clmobokuph7oq5jl5aobesjzyfblcjdrtma/
$ dig +short TXT _dnslink.www.4everland.org
[no result]
@whizzzkid we probably should address this right after MV3 lands. It degrades UX on websites that use IPFS for hosting or provide IPFS services (but have DNSLink misconfiguration).
I would go as far as Disabling x-ipfs-path
for all users by default, and also doing one-time migration, and making the below feature opt-in instead of opt-out:
As it is today, makes more harm than good, unfortunately.
https://fleek.co is an example of interesting misconfiguration (at least today 2022-02-17):
fleek.co
has no DNSLinkx-ipfs-path
to immutable snapshotProblem
Companion will use
x-ipfs-path
as fallback:https://github.com/ipfs/ipfs-companion/blob/eacee6ca786f669411c54e7cdde4c12876bf03cf/add-on/src/lib/ipfs-request.js#L310-L312
This means opening https://fleek.co with ipfs-companion will redirect user to http://bafybeidwgtlx54aifd5ynwwvlozr2fuw5xrmbu3ivnwmnoxi4ewdnxty5y.ipfs.localhost:8080
Solution
x-ipfs-path
, as that makes it hard for user to bookmark, access the latest version in the future, and could introduce regressions (only websites with valid DNSLink should be redirected).x-ipfs-path
, but the domain has no DNSLink set up.