search

ipfs / ipfs-companion

Browser extension that simplifies access to IPFS resources on the web
https://docs.ipfs.tech/install/ipfs-companion/
Creative Commons Zero v1.0 Universal
2.05k stars 325 forks source link

[deferred] Observe WebRequests and populate LFU Cache #1155

Open whizzzkid opened 1 year ago

whizzzkid commented 1 year ago

Parent Issue: https://github.com/ipfs/ipfs-companion/issues/1152

ETA: 2023-05-12

### Tasks
- [x] Observe webRequests via the non-blocking API
- [ ] Implement LFU  maintain list of LFU URLs that can be serviced by companion.
- [ ] Validate LFU thresholds to have sufficient content that exceeds the blockable requests.

Discussion Notes:

BigLep commented 1 year ago

@whizzzkid : I'm wondering if we're over complicating this. A couple of thoughts:

  1. We can store 5k regexes right? Do we have a sense of whether 5k+ domains even have "IPFS support"? Related, over the course of someone's browsing session, how many unique domains (regardless if they have "IPFS support") does one have? My guess is that 5k is plenty big enough. Before we do work here, lets just get a metric on how big we find this to be in practice.
  2. Once the 5k limit is hit, what happens when you try to add another regex? Do you get an error? Do you have to choose what regex to evict so thee is space for the new regex you want to add?
whizzzkid commented 1 year ago

@BigLep

Do we have a sense of whether 5k+ domains even have "IPFS support"? Related, over the course of someone's browsing session, how many unique domains (regardless if they have "IPFS support") does one have? My guess is that 5k is plenty big enough.

I agree, it does seem enough, however the second part answers this question.

Once the 5k limit is hit, what happens when you try to add another regex?

It's an error, this limit might change in the future if we're to believe chrome team. The cache would help us determine which rules are good to remove which needs to still be in there. In fact I was looking at 2Q cache implementation with a TTL, i.e. auto-purging all rules to free up space for more.

BigLep commented 1 year ago

Ok, got it. It's good to know we get an error and thus have a metric we can report.

I don't think we should put energy on being fancy for now. I think we should ship and then can improve this later if we see the need in the metrics.