ipfs / ipfs-companion

Browser extension that simplifies access to IPFS resources on the web
https://docs.ipfs.tech/install/ipfs-companion/
Creative Commons Zero v1.0 Universal
2.04k stars 323 forks source link

no chrome update shaming #1305

Closed ImprovedTube closed 6 months ago

ImprovedTube commented 7 months ago

if you fill in the blank, i can make another PR or commit like: chrome.runtime.onInstalled.addListener(function(installed){if(installed.reason=='install'){if 111 > Number(navigator.userAgent.match(new RegExp(chrome + '/([0-9]+)'))){alert("[Just to make sure:] Some of our features might require chrome version 111+.... _______________________") } ( - or rather add it precisely, when that feature is first enabled as indicated by it's button or storage change.)

welcome[bot] commented 7 months ago

Thank you for submitting this PR! A maintainer will be here shortly to review it. We are super grateful, but we are also overloaded! Help us by making sure that:

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment. Next steps:

We currently aim to provide initial feedback/triaging within seven business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. We are very grateful for your contribution!

whizzzkid commented 7 months ago

@ImprovedTube, I am not sure what issue is this PR trying to solve and how? This is not a supported use case for chrome extensions.

ImprovedTube commented 7 months ago

= why lock out multiple percent of the world? let them decide /try? most of your features might still work with chrome 109 or older?

whizzzkid commented 6 months ago

@ImprovedTube no that won't work, are you just assuming? MV3 is not available in prior versions of chrome.