ipfs / ipfs-companion

Browser extension that simplifies access to IPFS resources on the web
https://docs.ipfs.tech/install/ipfs-companion/
Creative Commons Zero v1.0 Universal
2.04k stars 321 forks source link

IPFS resource on non-IPFS page tries to redirect to https://cid.ipfs.localhost:8080 #1324

Open Jontes-Tech opened 3 weeks ago

Jontes-Tech commented 3 weeks ago

Describe the bug A clear and concise description of what the bug is. In chromium, http://localhost:8080/ipfs/cid redirects to https://cid.ipfs.localhost:8080. Kubo's gateway only serves HTTP, not HTTPS.

To Reproduce Steps to reproduce the behavior:

  1. Create an HTML (over HTTP) file.
  2. Create an <img> pointing to https://ipfs.io/ipfs/any-cid-here
  3. Image will fail to load because it tries to redirect to https on 8080.

Expected behavior A clear and concise description of what you expected to happen. Image loads successfully

Screenshots If applicable, add screenshots to help explain your problem. Screenshot from 2024-06-08 15-17-04

Desktop (please complete the following information):

lidel commented 3 weeks ago

@Jontes-Tech I was unable to reproduce in fresh install on Chrome 126.0.6478.36

Jontes-Tech commented 3 weeks ago

Yeah, sorry. Github stripped away my HTML tags. I've edited the message to make it clearer.

Basically http://localhost:8080/ipfs/cid should redirect to http://cid.ipfs.localhost:8080 but instead redirects to https://cid.ipfs.localhost:8080 when served as an image in an HTTPS context.

One example of this is present on the following webpage: https://ens.page/jontes.eth

You will see in the network tab how IPFS companion redirects to https:// on localhost.

See the screenshots I've attached: image image

Reproducible on both Chrome and Chromium, 125.0.6422.141 (Official Build) Arch Linux (64-bit)