search

ipfs / ipfs-companion

Browser extension that simplifies access to IPFS resources on the web
https://docs.ipfs.tech/install/ipfs-companion/
Creative Commons Zero v1.0 Universal
2.05k stars 325 forks source link

dweb:/ipfs/$cid not detected on Android #348

Open jefft0 opened 6 years ago

jefft0 commented 6 years ago

I have Firefox for Android 57.0.1 and IPFS companion 2.1.0. IPFS-like paths (/ipfs/$cid) are not redirected. (Are they supposed to be in this version?) (The same link redirect correctly in Firefox for Desktop.)

lidel commented 6 years ago

Yeah it seems the hack from https://github.com/ipfs-shipyard/ipfs-companion/issues/164#issuecomment-328374052 does not work on Android:

Can't do anything about it at this time – Firefox is lacking APIs (https://github.com/ipfs-shipyard/ipfs-companion/issues/164). Rewrites of href and src attributes in HTML should still work tho.

jefft0 commented 6 years ago

OK, thanks. You're aware of the problem. Is there another issue I can track for Android support? If so, you can close this issue.

lidel commented 6 years ago

I think for protocol support you can just follow #164, this will be addressed there. Other things should work on Android.

If not, please create separate issue for each problem you find on Android – we don't have robust test suite yet (#145) so such feedback is very much appreciated 👍

lidel commented 6 years ago

Reopening due to development described in https://github.com/ipfs-shipyard/ipfs-companion/issues/164#issuecomment-355708883

cvan commented 6 years ago

Apologies if I'm misunderstanding here. Just wanted to confirm: since https://bugzilla.mozilla.org/show_bug.cgi?id=1428446 has been merged and shipped (woo!), this issue will be moot when PR #359 is merged? Or is there another Firefox (for Android) bug to track here?

lidel commented 6 years ago

Yes, this will be closed when PR #359 is merged :)

lidel commented 6 years ago

I just smoke-tested latest master. Actually, while extension loads fine in Firefox for Android (v59 from Beta channel), it seems to be missing the UI for picking which extension should be a handler for dweb protocol.

Filled an upstream bug: