Rube Goldberg machine-like workflow breaks browser action menu

ipfs / ipfs-companion

Browser extension that simplifies access to IPFS resources on the web

https://docs.ipfs.tech/install/ipfs-companion/

Creative Commons Zero v1.0 Universal

2.06k stars 325 forks source link

Rube Goldberg machine-like workflow breaks browser action menu #388

Open lidel opened 6 years ago

lidel commented 6 years ago

Detected during tests of #381 under Firefox 58:

upload using embedded node
open tab with uploaded item (actually, it should open automatically after successful upload)
switch to external node
try to pin item → UI sometimes freezes

alanshaw commented 6 years ago

I guess if ipfs.io hasn't got the data yet or no other peer has the data already then it won't be able to pin it. Switching to external node will shut down the JS node so it can't be fetched from there anymore.

I would be willing to bet that the UI freezes up because it's waiting for IPFS to find the data for the hash, which it might never do.

I'm not sure what we'd be able to do about this, other than feedback to the user that IPFS is trying to resolve a hash....