search

ipfs / ipfs-companion

Browser extension that simplifies access to IPFS resources on the web
https://docs.ipfs.tech/install/ipfs-companion/
Creative Commons Zero v1.0 Universal
2.05k stars 325 forks source link

Support reading correct gateway port via API #591

Open timthelion opened 5 years ago

timthelion commented 5 years ago

See https://github.com/ipfs/go-ipfs/issues/5499

timthelion commented 5 years ago

Here is what I see when I click on the plug in link.

GATEWAY http://127.0.0.1:8080
API http://127.0.0.1:5001
VERSION 0.4.17
PEERS 512
lidel commented 5 years ago

Hm.. what makes gateway port "correct" ? :)

Based on provided data you are running the go-ipfs node on port :8080 and it has 512 peers. That is the default port Companion extension tries on first install, so far everything looks ok.

You mentioned also(?) running different gateway on :9001 – what is this about? If you prefer to use gateway running on different port just update "Custom Gateway URL" in Preferences.

Hope this helps. (Let me know if I am missing something here)

timthelion commented 5 years ago 
Based on provided data you are running the go-ipfs node on port :8080 and it has 512 peers.
That is the default port Companion extension tries on first install, so far everything looks ok.

This isn't correct. I believe that the companion is connected successfully to the HTTP/API on the default port. But I never had the IPFS gateway configured for 8080.

What I would expect to happen, is that the companion would have a way of finding out the correct gateway via the API. I think that this will be a common problem, because 8080 is an extremely common port to use for HTTP servers.

lidel commented 5 years ago

Ah, I think I got it now: so the bug-or-feature is that you are connected to API port of one node, but are using Gateway port of another one.

Automatic detection of gateway port by reading it from API was suggested in the past (https://github.com/ipfs-shipyard/ipfs-companion/pull/309) and we will need it for things like Brave integration, so it is on the roadmap.

Current plan is to deliver this feature as a part of https://github.com/ipfs-shipyard/ipfs-companion/issues/491. Stay tuned.

timthelion commented 5 years ago

Thanks. Closing as dup.

lidel commented 5 years ago

Let's keep it open as a part of milestone/14 :)