Replace shell scripts with JS code

ipfs / ipfs-companion

Browser extension that simplifies access to IPFS resources on the web

https://docs.ipfs.tech/install/ipfs-companion/

Creative Commons Zero v1.0 Universal

2.07k stars 324 forks source link

Replace shell scripts with JS code #932

Open lidel opened 4 years ago

lidel commented 4 years ago

Problem: ci/update-manifest.sh uses third party jq and that causes problems for contributors (https://github.com/ipfs-shipyard/ipfs-companion/issues/790#issuecomment-712682654).
Fix: replace it with .js util that is platform-agnostic (we want good devexp on Windows) and relies on dev dependencies listed in package.json

BrianBelhumeur commented 4 years ago

I can take this one. The json package seems like a good candidate.

To be clear, the goal is to replace the just the jq util, rather than the entire ci/update-manifest.sh shell script, correct?

lidel commented 4 years ago

@BrianBelhumeur Ideally we would replace entire update-manifest.sh with update-manifest.js that does the same but removes the need for shell scripts, but if we remove jq that also good enough, gets us 80% where we want to be :)

BrianBelhumeur commented 3 years ago

Hey @lidel I'm actually going to hand this one back. I don't currently have the bandwidth for it.