ipfs / ipfs-desktop

An unobtrusive and user-friendly desktop application for IPFS on Windows, Mac and Linux.
https://docs.ipfs.tech/install/ipfs-desktop/
MIT License
6.01k stars 865 forks source link

Debian package depends on libappindicator3-1 which does not exist in Debian stable #1904

Open m4lvin opened 3 years ago

m4lvin commented 3 years ago

The Bug

The debian package depends on libappindicator3-1, a package which no longer exists in the current stable version 11 of Debian: https://packages.debian.org/search?keywords=libappindicator3-1

To Reproduce

$ wget https://github.com/ipfs-shipyard/ipfs-desktop/releases/download/v0.16.2/ipfs-desktop-0.16.2-linux-amd64.deb
$ sudo apt install ./ipfs-desktop-0.16.2-linux-amd64.deb
[...]
Unpacking ipfs-desktop (0.16.2) ...
dpkg: dependency problems prevent configuration of ipfs-desktop:
 ipfs-desktop depends on libappindicator3-1; however:
  Package libappindicator3-1 is not installed.

dpkg: error processing package ipfs-desktop (--install):
 dependency problems - leaving unconfigured

Expected behavior The package should be installed and configured.

lidel commented 3 years ago

Thank you for filling this.

We could follow suggestion to manually set dependencies as suggested in https://github.com/electron-userland/electron-builder/pull/6225/files but this is brittle and forces us to manually manage deps going forward, which is shifting blame for future breakage to end users (us). Not the best.

I hope to see a proper fix in upstream library (electron-builder), namely change default deps to ones that does not break Debian by default :grimacing:

For now, end user can try the workaround from https://github.com/Clansty/Icalingua/issues/162#issuecomment-899255738 and manually install the deprecated lib.